Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix undefined behaviors #2130

Merged
merged 7 commits into from
Jul 9, 2024
Merged

fix undefined behaviors #2130

merged 7 commits into from
Jul 9, 2024

Conversation

enum-class
Copy link
Contributor

Summary

fix undefined behaviors, and one minor bug

Details and comments

@enum-class
Copy link
Contributor Author

Hi @doichanj and @hhorii ,
What is the procedure of p.r.'s ?
Could you please help me with it ?

@doichanj
Copy link
Collaborator

I think we have to use signed integer for OpenMP loop because it causes compilation error on Windows (it fails only on Windows...)

@doichanj doichanj merged commit e56cbbb into Qiskit:main Jul 9, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doichanj doichanj doichanj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enum-class @doichanj